yiguolei commented on code in PR #17389:
URL: https://github.com/apache/doris/pull/17389#discussion_r1124104807


##########
be/src/vec/sink/vtablet_sink.cpp:
##########
@@ -404,10 +409,24 @@ Status VNodeChannel::open_wait() {
     return status;
 }
 
+template Status VNodeChannel::add_block<true>(

Review Comment:
   这种模板不会提升太多的性能,不要加了,编译会很慢。直接 if else吧



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to