This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new b5b595519a [fix](log) use logger to replace printStackTrace() (#17382)
b5b595519a is described below
commit b5b595519a5d2de14249f3613eb80c1bfcf0c05c
Author: WenYao <729673...@qq.com>
AuthorDate: Fri Mar 3 14:51:30 2023 +0800
[fix](log) use logger to replace printStackTrace() (#17382)
Use Logger to replace printStackTrace to better locate problems.
---
.../main/java/org/apache/doris/common/io/Text.java | 2 +-
.../src/main/java/org/apache/doris/PaloFe.java | 6 +++---
.../java/org/apache/doris/analysis/SelectStmt.java | 2 +-
.../main/java/org/apache/doris/catalog/Env.java | 4 ++--
.../apache/doris/clone/TabletSchedulerStat.java | 9 ++++++---
.../src/main/java/org/apache/doris/ha/BDBHA.java | 2 +-
.../doris/httpv2/config/ReadEnvironment.java | 6 ++++--
.../doris/httpv2/controller/ConfigController.java | 6 ++++--
.../doris/httpv2/controller/HaController.java | 5 ++++-
.../doris/httpv2/controller/LogController.java | 1 -
.../apache/doris/httpv2/rest/MetricsAction.java | 6 ++++--
.../doris/httpv2/rest/RestBaseController.java | 4 ++--
.../apache/doris/journal/bdbje/BDBEnvironment.java | 6 +++---
.../apache/doris/journal/bdbje/BDBJEJournal.java | 4 ++--
.../org/apache/doris/journal/bdbje/BDBTool.java | 10 ++++++----
.../org/apache/doris/mysql/MysqlSerializer.java | 9 ++++++---
.../nereids/jobs/cascades/CostAndEnforcerJob.java | 5 ++++-
.../java/org/apache/doris/qe/ShowExecutor.java | 2 +-
.../java/org/apache/doris/qe/StmtExecutor.java | 22 +++++++---------------
.../apache/doris/statistics/ColumnStatistic.java | 1 -
.../org/apache/doris/statistics/Histogram.java | 1 -
.../java/org/apache/doris/udf/BitmapAndUDF.java | 6 ++++--
.../java/org/apache/doris/udf/BitmapCountUDF.java | 6 ++++--
.../java/org/apache/doris/udf/BitmapOrUDF.java | 6 ++++--
.../java/org/apache/doris/udf/BitmapXorUDF.java | 6 ++++--
.../doris/load/loadv2/dpp/SparkRDDAggregator.java | 8 ++++++--
.../apache/doris/load/loadv2/etl/SparkEtlJob.java | 2 +-
27 files changed, 84 insertions(+), 63 deletions(-)
diff --git a/fe/fe-common/src/main/java/org/apache/doris/common/io/Text.java
b/fe/fe-common/src/main/java/org/apache/doris/common/io/Text.java
index 1710cb34e2..76256f30fe 100644
--- a/fe/fe-common/src/main/java/org/apache/doris/common/io/Text.java
+++ b/fe/fe-common/src/main/java/org/apache/doris/common/io/Text.java
@@ -175,7 +175,7 @@ public class Text implements Writable {
return -1; // not found
} catch (CharacterCodingException e) {
// can't get here
- e.printStackTrace();
+ LOG.warn("", e);
return -1;
}
}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/PaloFe.java
b/fe/fe-core/src/main/java/org/apache/doris/PaloFe.java
index 6de318fd7b..4333cfb480 100755
--- a/fe/fe-core/src/main/java/org/apache/doris/PaloFe.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/PaloFe.java
@@ -179,7 +179,7 @@ public class PaloFe {
Thread.sleep(2000);
}
} catch (Throwable e) {
- e.printStackTrace();
+ LOG.warn("", e);
}
}
@@ -245,7 +245,7 @@ public class PaloFe {
try {
cmd = commandLineParser.parse(options, args);
} catch (final ParseException e) {
- e.printStackTrace();
+ LOG.warn("", e);
System.err.println("Failed to parse command line. exit now");
System.exit(-1);
}
@@ -357,7 +357,7 @@ public class PaloFe {
System.out.println("Load image success. Image file " +
cmdLineOpts.getImagePath() + " is valid");
} catch (Exception e) {
System.out.println("Load image failed. Image file " +
cmdLineOpts.getImagePath() + " is invalid");
- e.printStackTrace();
+ LOG.warn("", e);
} finally {
System.exit(0);
}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/SelectStmt.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/SelectStmt.java
index 9382c01edf..318426b1f7 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/SelectStmt.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/SelectStmt.java
@@ -469,7 +469,7 @@ public class SelectStmt extends QueryStmt {
tableRef.setOnClause(expr.trySubstitute(mvSMap,
analyzer, false));
}
} catch (Exception e) {
- e.printStackTrace();
+ LOG.warn("", e);
}
}
}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
index fa4eada867..e86ab60d39 100755
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
@@ -1000,7 +1000,7 @@ public class Env {
Thread.sleep(5000);
continue;
} catch (InterruptedException e) {
- e.printStackTrace();
+ LOG.warn("", e);
System.exit(-1);
}
}
@@ -1347,7 +1347,7 @@ public class Env {
try {
Thread.sleep(10 * 1000);
} catch (InterruptedException e) {
- e.printStackTrace();
+ LOG.warn("", e);
}
}
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/clone/TabletSchedulerStat.java
b/fe/fe-core/src/main/java/org/apache/doris/clone/TabletSchedulerStat.java
index 74120c4e44..7510b06fe2 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/clone/TabletSchedulerStat.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/clone/TabletSchedulerStat.java
@@ -18,6 +18,8 @@
package org.apache.doris.clone;
import com.google.common.collect.Lists;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import java.lang.annotation.ElementType;
import java.lang.annotation.Retention;
@@ -31,6 +33,7 @@ import java.util.concurrent.atomic.AtomicLong;
* A simple statistic of tablet checker and scheduler
*/
public class TabletSchedulerStat {
+ private static final Logger LOG =
LogManager.getLogger(TabletSchedulerStat.class);
@Target({ ElementType.FIELD })
@Retention(RetentionPolicy.RUNTIME)
@@ -132,7 +135,7 @@ public class TabletSchedulerStat {
((AtomicLong) field.get(lastSnapshot)).set(((AtomicLong)
field.get(this)).get());
}
} catch (ClassNotFoundException | IllegalArgumentException |
IllegalAccessException e) {
- e.printStackTrace();
+ LOG.warn("", e);
lastSnapshot = null;
}
}
@@ -157,7 +160,7 @@ public class TabletSchedulerStat {
result.add(info);
}
} catch (ClassNotFoundException | IllegalArgumentException |
IllegalAccessException e) {
- e.printStackTrace();
+ LOG.warn("", e);
return Lists.newArrayList();
}
return result;
@@ -183,7 +186,7 @@ public class TabletSchedulerStat {
sb.append(current).append(" (+").append(current -
last).append(")\n");
}
} catch (ClassNotFoundException | IllegalArgumentException |
IllegalAccessException e) {
- e.printStackTrace();
+ LOG.warn("", e);
return "";
}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/ha/BDBHA.java
b/fe/fe-core/src/main/java/org/apache/doris/ha/BDBHA.java
index 1c3a99c1dc..53b0f6758f 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/ha/BDBHA.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/ha/BDBHA.java
@@ -101,7 +101,7 @@ public class BDBHA implements HAProtocol {
try {
Thread.sleep(2000);
} catch (InterruptedException e1) {
- e1.printStackTrace();
+ LOG.warn("", e1);
}
}
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/config/ReadEnvironment.java
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/config/ReadEnvironment.java
index a8dfd29a03..974c86d246 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/config/ReadEnvironment.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/config/ReadEnvironment.java
@@ -19,6 +19,8 @@ package org.apache.doris.httpv2.config;
import org.apache.doris.common.Log4jConfig;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import org.springframework.beans.BeansException;
import org.springframework.boot.logging.LogFile;
import org.springframework.boot.logging.LoggingInitializationContext;
@@ -34,7 +36,7 @@ import java.io.File;
@Component
public class ReadEnvironment implements ApplicationContextAware {
-
+ private static final Logger LOG =
LogManager.getLogger(ReadEnvironment.class);
private ApplicationContext applicationContext;
@Override
@@ -59,7 +61,7 @@ public class ReadEnvironment implements
ApplicationContextAware {
system.initialize(new LoggingInitializationContext(environment),
logConfig, logFile);
} catch (Exception ex) {
- ex.printStackTrace();
+ LOG.warn("", ex);
}
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/ConfigController.java
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/ConfigController.java
index cbb3024121..a983b81f68 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/ConfigController.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/ConfigController.java
@@ -22,6 +22,8 @@ import org.apache.doris.httpv2.entity.ResponseEntityBuilder;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RequestMethod;
import org.springframework.web.bind.annotation.RestController;
@@ -33,7 +35,7 @@ import java.util.Map;
@RestController
@RequestMapping("/rest/v1")
public class ConfigController {
-
+ private static final Logger LOG =
LogManager.getLogger(ConfigController.class);
private static final List<String> CONFIG_TABLE_HEADER =
Lists.newArrayList("Name", "Value");
@RequestMapping(path = "/config/fe", method = RequestMethod.GET)
@@ -57,7 +59,7 @@ public class ConfigController {
list.add(info);
}
} catch (Exception e) {
- e.printStackTrace();
+ LOG.warn("", e);
}
}
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/HaController.java
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/HaController.java
index 129b9d6cb4..f0bb84dbb8 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/HaController.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/HaController.java
@@ -24,6 +24,8 @@ import org.apache.doris.httpv2.entity.ResponseEntityBuilder;
import org.apache.doris.persist.Storage;
import org.apache.doris.system.Frontend;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RequestMethod;
import org.springframework.web.bind.annotation.RestController;
@@ -39,6 +41,7 @@ import java.util.Map;
@RestController
@RequestMapping("/rest/v1")
public class HaController {
+ private static final Logger LOG = LogManager.getLogger(HaController.class);
@RequestMapping(path = "/ha", method = RequestMethod.GET)
public Object ha() {
@@ -145,7 +148,7 @@ public class HaController {
result.put("CheckpointInfo", list);
} catch (IOException e) {
- e.printStackTrace();
+ LOG.warn("", e);
}
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/LogController.java
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/LogController.java
index db04dc3499..478a1a0e0f 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/LogController.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/LogController.java
@@ -104,7 +104,6 @@ public class LogController {
content.put("LogConfiguration", map);
} catch (IOException e) {
LOG.error(e);
- e.printStackTrace();
}
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/MetricsAction.java
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/MetricsAction.java
index 0026717c7a..1581c28a31 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/MetricsAction.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/MetricsAction.java
@@ -25,6 +25,8 @@ import org.apache.doris.metric.PrometheusMetricVisitor;
import org.apache.doris.metric.SimpleCoreMetricVisitor;
import com.google.common.base.Strings;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RestController;
@@ -36,7 +38,7 @@ import javax.servlet.http.HttpServletResponse;
//fehost:port/metrics?type=core
@RestController
public class MetricsAction extends RestBaseController {
-
+ private static final Logger LOG =
LogManager.getLogger(MetricsAction.class);
private static final String TYPE_PARAM = "type";
@RequestMapping(path = "/metrics")
@@ -58,7 +60,7 @@ public class MetricsAction extends RestBaseController {
try {
response.getWriter().write(MetricRepo.getMetric(visitor));
} catch (IOException e) {
- e.printStackTrace();
+ LOG.warn("", e);
}
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/RestBaseController.java
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/RestBaseController.java
index 2f56831d44..1d8a71def3 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/RestBaseController.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/RestBaseController.java
@@ -138,14 +138,14 @@ public class RestBaseController extends BaseController {
try {
bis.close();
} catch (IOException e) {
- e.printStackTrace();
+ LOG.warn("", e);
}
}
if (fis != null) {
try {
fis.close();
} catch (IOException e) {
- e.printStackTrace();
+ LOG.warn("", e);
}
}
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBEnvironment.java
b/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBEnvironment.java
index 8b8c9feda9..8ee4a21d88 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBEnvironment.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBEnvironment.java
@@ -201,7 +201,7 @@ public class BDBEnvironment {
try {
Thread.sleep(5 * 1000);
} catch (InterruptedException e1) {
- e1.printStackTrace();
+ LOG.warn("", e1);
}
} else {
LOG.error("error to open replicated environment. will
exit.", e);
@@ -342,7 +342,7 @@ public class BDBEnvironment {
try {
Thread.sleep(1000);
} catch (InterruptedException e1) {
- e1.printStackTrace();
+ LOG.warn("", e1);
}
} catch (DatabaseException e) {
LOG.warn("catch an exception when calling getDatabaseNames",
e);
@@ -421,7 +421,7 @@ public class BDBEnvironment {
try {
Thread.sleep(5 * 1000);
} catch (InterruptedException e1) {
- e1.printStackTrace();
+ LOG.warn("", e1);
}
} else {
LOG.error("error to open replicated environment. will
exit.", e);
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBJEJournal.java
b/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBJEJournal.java
index 82ad6a8cda..38746bb4a7 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBJEJournal.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBJEJournal.java
@@ -156,7 +156,7 @@ public class BDBJEJournal implements Journal { //
CHECKSTYLE IGNORE THIS LINE: B
try {
Thread.sleep(5 * 1000);
} catch (InterruptedException e1) {
- e1.printStackTrace();
+ LOG.warn("", e1);
}
}
}
@@ -221,7 +221,7 @@ public class BDBJEJournal implements Journal { //
CHECKSTYLE IGNORE THIS LINE: B
try {
ret.readFields(in);
} catch (IOException e) {
- e.printStackTrace();
+ LOG.warn("", e);
}
} else {
System.out.println("No record found for key '" + journalId +
"'.");
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBTool.java
b/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBTool.java
index bfb8045bb2..cc9defa378 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBTool.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBTool.java
@@ -33,6 +33,8 @@ import com.sleepycat.je.Environment;
import com.sleepycat.je.EnvironmentConfig;
import com.sleepycat.je.LockMode;
import com.sleepycat.je.OperationStatus;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import org.json.simple.JSONArray;
import org.json.simple.JSONObject;
@@ -44,7 +46,7 @@ import java.util.List;
import java.util.Map;
public class BDBTool {
-
+ private static final Logger LOG = LogManager.getLogger(BDBTool.class);
private String metaPath;
private BDBToolOptions options;
@@ -63,7 +65,7 @@ public class BDBTool {
try {
env = new Environment(new File(metaPath), envConfig);
} catch (DatabaseException e) {
- e.printStackTrace();
+ LOG.warn("", e);
System.err.println("Failed to open BDBJE env: " +
Env.getCurrentEnv().getBdbDir() + ". exit");
return false;
}
@@ -129,7 +131,7 @@ public class BDBTool {
}
}
} catch (Exception e) {
- e.printStackTrace();
+ LOG.warn("", e);
System.err.println("Failed to run bdb tools");
return false;
}
@@ -152,7 +154,7 @@ public class BDBTool {
try {
entity.readFields(in);
} catch (Exception e) {
- e.printStackTrace();
+ LOG.warn("", e);
System.err.println("Fail to read journal entity for key: " +
key + ". reason: " + e.getMessage());
System.exit(-1);
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/mysql/MysqlSerializer.java
b/fe/fe-core/src/main/java/org/apache/doris/mysql/MysqlSerializer.java
index d39bc4d77d..44564d4765 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/mysql/MysqlSerializer.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/mysql/MysqlSerializer.java
@@ -21,6 +21,8 @@ import org.apache.doris.catalog.Column;
import org.apache.doris.catalog.PrimitiveType;
import com.google.common.base.Strings;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import java.io.ByteArrayOutputStream;
import java.io.UnsupportedEncodingException;
@@ -28,6 +30,7 @@ import java.nio.ByteBuffer;
// used for serialize memory data to byte stream of MySQL protocol
public class MysqlSerializer {
+ private static final Logger LOG =
LogManager.getLogger(MysqlSerializer.class);
private ByteArrayOutputStream out;
private MysqlCapability capability;
@@ -134,7 +137,7 @@ public class MysqlSerializer {
writeVInt(buf.length);
writeBytes(buf);
} catch (UnsupportedEncodingException e) {
- e.printStackTrace();
+ LOG.warn("", e);
}
}
@@ -143,7 +146,7 @@ public class MysqlSerializer {
byte[] buf = value.getBytes("UTF-8");
writeBytes(buf);
} catch (UnsupportedEncodingException e) {
- e.printStackTrace();
+ LOG.warn("", e);
}
}
@@ -153,7 +156,7 @@ public class MysqlSerializer {
writeBytes(buf);
writeByte((byte) 0);
} catch (UnsupportedEncodingException e) {
- e.printStackTrace();
+ LOG.warn("", e);
}
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/CostAndEnforcerJob.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/CostAndEnforcerJob.java
index 2f1c26472d..9a5d410d20 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/CostAndEnforcerJob.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/CostAndEnforcerJob.java
@@ -32,6 +32,8 @@ import
org.apache.doris.nereids.properties.RequestPropertyDeriver;
import org.apache.doris.nereids.stats.StatsCalculator;
import com.google.common.collect.Lists;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import java.util.ArrayList;
import java.util.List;
@@ -42,6 +44,7 @@ import java.util.Optional;
* Inspired by NoisePage and ORCA-Paper.
*/
public class CostAndEnforcerJob extends Job implements Cloneable {
+ private static final Logger LOG =
LogManager.getLogger(CostAndEnforcerJob.class);
// GroupExpression to optimize
private final GroupExpression groupExpression;
@@ -314,7 +317,7 @@ public class CostAndEnforcerJob extends Job implements
Cloneable {
// TODO: need to implement this method
job = (CostAndEnforcerJob) super.clone();
} catch (CloneNotSupportedException e) {
- e.printStackTrace();
+ LOG.warn("", e);
throw new RuntimeException("clone cost and enforcer job failed.");
}
return job;
diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/ShowExecutor.java
b/fe/fe-core/src/main/java/org/apache/doris/qe/ShowExecutor.java
index 5e4d0e5f2c..d7090f196d 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/qe/ShowExecutor.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/qe/ShowExecutor.java
@@ -1935,7 +1935,7 @@ public class ShowExecutor {
dynamicPartitionProperty.getSortedReservedHistoryPeriods(unsortedReservedHistoryPeriods,
dynamicPartitionProperty.getTimeUnit().toUpperCase())));
} catch (DdlException e) {
- e.printStackTrace();
+ LOG.warn("", e);
} finally {
olapTable.readUnlock();
}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
b/fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
index bf34dd03a9..0ba673baa9 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
@@ -525,7 +525,6 @@ public class StmtExecutor implements ProfileWriter {
Env.getCurrentEnv().getSqlBlockRuleMgr().matchSql(
originStmt.originStmt, context.getSqlHash(),
context.getQualifiedUser());
} catch (AnalysisException e) {
- e.printStackTrace();
LOG.warn(e.getMessage());
context.getState().setError(e.getMysqlErrorCode(),
e.getMessage());
return;
@@ -618,21 +617,19 @@ public class StmtExecutor implements ProfileWriter {
context.getState().setError(ErrorCode.ERR_NOT_SUPPORTED_YET,
"Do not support this query.");
}
} catch (IOException e) {
- e.printStackTrace();
LOG.warn("execute IOException. {}", context.getQueryIdentifier(),
e);
// the exception happens when interact with client
// this exception shows the connection is gone
context.getState().setError(ErrorCode.ERR_UNKNOWN_ERROR,
e.getMessage());
throw e;
} catch (UserException e) {
- e.printStackTrace();
+ LOG.warn("", e);
// analysis exception only print message, not print the stack
LOG.warn("execute Exception. {}, {}", context.getQueryIdentifier(),
e.getMessage());
context.getState().setError(e.getMysqlErrorCode(), e.getMessage());
context.getState().setErrType(QueryState.ErrType.ANALYSIS_ERR);
} catch (Exception e) {
- e.printStackTrace();
LOG.warn("execute Exception. {}", context.getQueryIdentifier(), e);
context.getState().setError(ErrorCode.ERR_UNKNOWN_ERROR,
e.getClass().getSimpleName() + ", msg: " +
Util.getRootCauseMessage(e));
@@ -649,7 +646,6 @@ public class StmtExecutor implements ProfileWriter {
sessionVariable.setIsSingleSetVar(false);
sessionVariable.clearSessionOriginValue();
} catch (DdlException e) {
- e.printStackTrace();
LOG.warn("failed to revert Session value. {}",
context.getQueryIdentifier(), e);
context.getState().setError(e.getMysqlErrorCode(),
e.getMessage());
}
@@ -825,7 +821,6 @@ public class StmtExecutor implements ProfileWriter {
if (parsedStmt instanceof LogicalPlanAdapter) {
throw new NereidsException(new
AnalysisException("Unexpected exception: " + e.getMessage(), e));
}
- e.printStackTrace();
throw new AnalysisException("Unexpected exception: " +
e.getMessage());
} finally {
MetaLockUtils.readUnlockTables(tables);
@@ -1047,7 +1042,7 @@ public class StmtExecutor implements ProfileWriter {
SetExecutor executor = new SetExecutor(context, setStmt);
executor.execute();
} catch (DdlException e) {
- e.printStackTrace();
+ LOG.warn("", e);
// Return error message to client.
context.getState().setError(ErrorCode.ERR_LOCAL_VARIABLE,
e.getMessage());
return;
@@ -1724,7 +1719,7 @@ public class StmtExecutor implements ProfileWriter {
try {
context.getEnv().changeCatalog(context,
switchStmt.getCatalogName());
} catch (DdlException e) {
- e.printStackTrace();
+ LOG.warn("", e);
context.getState().setError(e.getMysqlErrorCode(), e.getMessage());
return;
}
@@ -1758,7 +1753,7 @@ public class StmtExecutor implements ProfileWriter {
}
context.getEnv().changeDb(context, useStmt.getDatabase());
} catch (DdlException e) {
- e.printStackTrace();
+ LOG.warn("", e);
context.getState().setError(e.getMysqlErrorCode(), e.getMessage());
return;
}
@@ -1927,15 +1922,13 @@ public class StmtExecutor implements ProfileWriter {
DdlExecutor.execute(context.getEnv(), (DdlStmt) parsedStmt);
context.getState().setOk();
} catch (QueryStateException e) {
- e.printStackTrace();
+ LOG.warn("", e);
context.setState(e.getQueryState());
} catch (UserException e) {
- e.printStackTrace();
// Return message to info client what happened.
- LOG.debug("DDL statement({}) process failed.",
originStmt.originStmt, e);
+ LOG.warn("DDL statement({}) process failed.",
originStmt.originStmt, e);
context.getState().setError(e.getMysqlErrorCode(), e.getMessage());
} catch (Exception e) {
- e.printStackTrace();
// Maybe our bug
LOG.warn("DDL statement(" + originStmt.originStmt + ") process
failed.", e);
context.getState().setError(ErrorCode.ERR_UNKNOWN_ERROR,
"Unexpected exception: " + e.getMessage());
@@ -1949,7 +1942,7 @@ public class StmtExecutor implements ProfileWriter {
context.getEnv().changeCluster(context,
enterStmt.getClusterName());
context.setDatabase("");
} catch (DdlException e) {
- e.printStackTrace();
+ LOG.warn("", e);
context.getState().setError(e.getMysqlErrorCode(), e.getMessage());
return;
}
@@ -1968,7 +1961,6 @@ public class StmtExecutor implements ProfileWriter {
DdlExecutor.execute(context.getEnv(), ctasStmt);
context.getState().setOk();
} catch (Exception e) {
- e.printStackTrace();
// Maybe our bug
LOG.warn("CTAS create table error, stmt={}",
originStmt.originStmt, e);
context.getState().setError(ErrorCode.ERR_UNKNOWN_ERROR,
"Unexpected exception: " + e.getMessage());
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStatistic.java
b/fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStatistic.java
index 3a47e368c8..2485ff72ba 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStatistic.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStatistic.java
@@ -134,7 +134,6 @@ public class ColumnStatistic {
columnStatisticBuilder.setSelectivity(1.0);
return columnStatisticBuilder.build();
} catch (Exception e) {
- e.printStackTrace();
LOG.warn("Failed to deserialize column statistics, column not
exists", e);
return ColumnStatistic.DEFAULT;
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/statistics/Histogram.java
b/fe/fe-core/src/main/java/org/apache/doris/statistics/Histogram.java
index 2e19b29f4f..f07155a9f5 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/statistics/Histogram.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/statistics/Histogram.java
@@ -98,7 +98,6 @@ public class Histogram {
return histogramBuilder.build();
} catch (Exception e) {
- e.printStackTrace();
LOG.warn("Failed to deserialize histogram statistics.", e);
return Histogram.DEFAULT;
}
diff --git a/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapAndUDF.java
b/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapAndUDF.java
index 413f3e15b1..cc84c5afaf 100644
--- a/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapAndUDF.java
+++ b/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapAndUDF.java
@@ -27,13 +27,15 @@ import org.apache.hadoop.hive.ql.udf.generic.GenericUDF;
import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector;
import
org.apache.hadoop.hive.serde2.objectinspector.primitive.BinaryObjectInspector;
import
org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import java.io.IOException;
@Description(name = "bitmap_and", value = "a _FUNC_ b - Compute intersection
of two or more input bitmaps,"
+ " return the new bitmap")
public class BitmapAndUDF extends GenericUDF {
-
+ private static final Logger LOG = LogManager.getLogger(BitmapAndUDF.class);
private transient BinaryObjectInspector inputOI0;
private transient BinaryObjectInspector inputOI1;
@@ -66,7 +68,7 @@ public class BitmapAndUDF extends GenericUDF {
bitmapValue0.and(bitmapValue1);
return BitmapValueUtil.serializeToBytes(bitmapValue1);
} catch (IOException ioException) {
- ioException.printStackTrace();
+ LOG.warn("", ioException);
throw new RuntimeException(ioException);
}
}
diff --git a/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapCountUDF.java
b/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapCountUDF.java
index a58041bf5d..28475610ec 100644
--- a/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapCountUDF.java
+++ b/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapCountUDF.java
@@ -27,13 +27,15 @@ import org.apache.hadoop.hive.ql.udf.generic.GenericUDF;
import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector;
import
org.apache.hadoop.hive.serde2.objectinspector.primitive.BinaryObjectInspector;
import
org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import java.io.IOException;
@Description(name = "bitmap_count", value = "a _FUNC_ b - Returns the number
of distinct integers"
+ " added to the bitmap (e.g., number of bits set)")
public class BitmapCountUDF extends GenericUDF {
-
+ private static final Logger LOG =
LogManager.getLogger(BitmapCountUDF.class);
private transient BinaryObjectInspector inputOI;
@Override
@@ -60,7 +62,7 @@ public class BitmapCountUDF extends GenericUDF {
BitmapValue bitmapValue =
BitmapValueUtil.deserializeToBitmap(inputBytes);
return bitmapValue.cardinality();
} catch (IOException ioException) {
- ioException.printStackTrace();
+ LOG.warn("", ioException);
throw new HiveException(ioException);
}
}
diff --git a/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapOrUDF.java
b/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapOrUDF.java
index 2bc5910ed0..197e137946 100644
--- a/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapOrUDF.java
+++ b/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapOrUDF.java
@@ -27,13 +27,15 @@ import org.apache.hadoop.hive.ql.udf.generic.GenericUDF;
import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector;
import
org.apache.hadoop.hive.serde2.objectinspector.primitive.BinaryObjectInspector;
import
org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import java.io.IOException;
@Description(name = "bitmap_or", value = "a _FUNC_ b - Compute"
+ " union of two or more input bitmaps, returns the new bitmap")
public class BitmapOrUDF extends GenericUDF {
-
+ private static final Logger LOG = LogManager.getLogger(BitmapOrUDF.class);
private transient BinaryObjectInspector inputOI0;
private transient BinaryObjectInspector inputOI1;
@@ -66,7 +68,7 @@ public class BitmapOrUDF extends GenericUDF {
bitmapValue0.or(bitmapValue1);
return BitmapValueUtil.serializeToBytes(bitmapValue1);
} catch (IOException ioException) {
- ioException.printStackTrace();
+ LOG.warn("", ioException);
throw new RuntimeException(ioException);
}
}
diff --git a/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapXorUDF.java
b/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapXorUDF.java
index 9096c3cf9d..d6c23f7dbb 100644
--- a/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapXorUDF.java
+++ b/fe/hive-udf/src/main/java/org/apache/doris/udf/BitmapXorUDF.java
@@ -27,13 +27,15 @@ import org.apache.hadoop.hive.ql.udf.generic.GenericUDF;
import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector;
import
org.apache.hadoop.hive.serde2.objectinspector.primitive.BinaryObjectInspector;
import
org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import java.io.IOException;
@Description(name = "bitmap_xor", value = "a _FUNC_ b - Compute the symmetric"
+ " union of two or more input bitmaps, return the new bitmap")
public class BitmapXorUDF extends GenericUDF {
-
+ private static final Logger LOG = LogManager.getLogger(BitmapXorUDF.class);
private transient BinaryObjectInspector inputOI0;
private transient BinaryObjectInspector inputOI1;
@@ -66,7 +68,7 @@ public class BitmapXorUDF extends GenericUDF {
bitmapValue0.xor(bitmapValue1);
return BitmapValueUtil.serializeToBytes(bitmapValue1);
} catch (IOException ioException) {
- ioException.printStackTrace();
+ LOG.warn("", ioException);
throw new RuntimeException(ioException);
}
}
diff --git
a/fe/spark-dpp/src/main/java/org/apache/doris/load/loadv2/dpp/SparkRDDAggregator.java
b/fe/spark-dpp/src/main/java/org/apache/doris/load/loadv2/dpp/SparkRDDAggregator.java
index cd5f8f7940..0e140af13c 100644
---
a/fe/spark-dpp/src/main/java/org/apache/doris/load/loadv2/dpp/SparkRDDAggregator.java
+++
b/fe/spark-dpp/src/main/java/org/apache/doris/load/loadv2/dpp/SparkRDDAggregator.java
@@ -24,6 +24,8 @@ import org.apache.doris.sparkdpp.EtlJobConfig;
import org.apache.commons.lang3.StringUtils;
import org.apache.commons.lang3.tuple.Pair;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
import org.apache.spark.Partitioner;
import org.apache.spark.api.java.function.Function2;
import org.apache.spark.api.java.function.PairFunction;
@@ -247,6 +249,7 @@ class ReplaceIfNotNullAggregator extends
SparkRDDAggregator<Object> {
}
class BitmapUnionAggregator extends SparkRDDAggregator<BitmapValue> {
+ private static final Logger LOG =
LogManager.getLogger(BitmapUnionAggregator.class);
@Override
BitmapValue init(Object value) {
@@ -283,7 +286,7 @@ class BitmapUnionAggregator extends
SparkRDDAggregator<BitmapValue> {
((BitmapValue) value).serialize(outputStream);
return bos.toByteArray();
} catch (IOException ioException) {
- ioException.printStackTrace();
+ LOG.warn("", ioException);
throw new RuntimeException(ioException);
}
}
@@ -291,6 +294,7 @@ class BitmapUnionAggregator extends
SparkRDDAggregator<BitmapValue> {
}
class HllUnionAggregator extends SparkRDDAggregator<Hll> {
+ private static final Logger LOG =
LogManager.getLogger(HllUnionAggregator.class);
@Override
Hll init(Object value) {
@@ -327,7 +331,7 @@ class HllUnionAggregator extends SparkRDDAggregator<Hll> {
((Hll) value).serialize(outputStream);
return bos.toByteArray();
} catch (IOException ioException) {
- ioException.printStackTrace();
+ LOG.warn("", ioException);
throw new RuntimeException(ioException);
}
}
diff --git
a/fe/spark-dpp/src/main/java/org/apache/doris/load/loadv2/etl/SparkEtlJob.java
b/fe/spark-dpp/src/main/java/org/apache/doris/load/loadv2/etl/SparkEtlJob.java
index ab9a1f0018..34f4c0a8c3 100644
---
a/fe/spark-dpp/src/main/java/org/apache/doris/load/loadv2/etl/SparkEtlJob.java
+++
b/fe/spark-dpp/src/main/java/org/apache/doris/load/loadv2/etl/SparkEtlJob.java
@@ -262,7 +262,7 @@ public class SparkEtlJob {
new SparkEtlJob(args[0]).run();
} catch (Exception e) {
System.err.println("spark etl job run failed");
- e.printStackTrace();
+ LOG.warn("", e);
System.exit(-1);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
