This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new c96571c236 [Bug](decimalv2) decimal value is filtered by mistake
(#17353)
c96571c236 is described below
commit c96571c236ffbff5e775e536cd17968225aaacc8
Author: Gabriel <gabrielleeb...@gmail.com>
AuthorDate: Fri Mar 3 10:40:19 2023 +0800
[Bug](decimalv2) decimal value is filtered by mistake (#17353)
Reason: column_name[k5], decimal value is not valid for definition,
value=123.123, precision=9, scale=3, min=-999999.999, max=-999999.999; . src
line [];
#17273
---
be/src/runtime/decimalv2_value.cpp | 2 --
1 file changed, 2 deletions(-)
diff --git a/be/src/runtime/decimalv2_value.cpp
b/be/src/runtime/decimalv2_value.cpp
index 3d7f56c047..77b3d6f451 100644
--- a/be/src/runtime/decimalv2_value.cpp
+++ b/be/src/runtime/decimalv2_value.cpp
@@ -447,7 +447,6 @@ std::string DecimalV2Value::to_string() const {
// NOTE: only change abstract value, do not change sign
void DecimalV2Value::to_max_decimal(int32_t precision, int32_t scale) {
- bool is_negative = (_value < 0);
static const int64_t INT_MAX_VALUE[PRECISION] = {9ll,
99ll,
999ll,
@@ -486,7 +485,6 @@ void DecimalV2Value::to_max_decimal(int32_t precision,
int32_t scale) {
int64_t int_value = INT_MAX_VALUE[precision - scale - 1];
int64_t frac_value = scale == 0 ? 0 : FRAC_MAX_VALUE[scale - 1];
_value = static_cast<int128_t>(int_value) * DecimalV2Value::ONE_BILLION +
frac_value;
- if (is_negative) _value = -_value;
}
std::size_t hash_value(DecimalV2Value const& value) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
