englefly commented on code in PR #17315:
URL: https://github.com/apache/doris/pull/17315#discussion_r1123043171
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -794,12 +794,19 @@ public PlanFragment visitPhysicalWindow(PhysicalWindow<?
extends Plan> physicalW
if (partitionExprs.isEmpty() && orderByElements.isEmpty()) {
if (inputPlanFragment.isPartitioned()) {
- inputPlanFragment = createParentFragment(inputPlanFragment,
DataPartition.UNPARTITIONED, context);
Review Comment:
when fragment.root is exchange, it is wrong to call
createParentFragment(fragment, ...)
How about move this logical into createParentFragment, or remove this
function.
it is error prone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
