yuxuan-luo commented on code in PR #17291:
URL: https://github.com/apache/doris/pull/17291#discussion_r1122690347


##########
be/src/runtime/routine_load/routine_load_task_executor.cpp:
##########
@@ -320,8 +320,8 @@ void 
RoutineLoadTaskExecutor::exec_task(std::shared_ptr<StreamLoadContext> ctx,
 
         std::vector<RdKafka::TopicPartition*> topic_partitions;
         for (auto& kv : ctx->kafka_info->cmt_offset) {
-            RdKafka::TopicPartition* tp1 =
-                    RdKafka::TopicPartition::create(ctx->kafka_info->topic, 
kv.first, kv.second);

Review Comment:
   The offsets you commit are the offsets of the messages you want to read next 
(not the offsets of the messages you did read last).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to