SaintBacchus commented on code in PR #17249:
URL: https://github.com/apache/doris/pull/17249#discussion_r1122630856
##########
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java:
##########
@@ -640,12 +640,13 @@ public String getCurrentConnectedFEIp() {
return currentConnectedFEIp;
}
- public void resetExecTimeout() {
- if (executor != null && executor.isInsertStmt()) {
- // particular timeout for insert stmt, we can make other
particular timeout in the same way.
- // set the execution timeout as max(insert_timeout,query_timeout)
to be compatible with older versions
- executionTimeoutS = Math.max(sessionVariable.getInsertTimeoutS(),
executionTimeoutS);
- }
+ public void setExecTimeout(int timeout) {
+ executionTimeoutS = timeout;
+ }
+
+ public long resetExecTimeoutByInsert() {
Review Comment:
@TangSiyang2001 I think this is more clean to understand since now it only
used by insert. But I keep `setExecTimeout` for future use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
