englefly commented on code in PR #16927: URL: https://github.com/apache/doris/pull/16927#discussion_r1121383357
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalNestedLoopJoin.java: ########## @@ -137,4 +146,16 @@ public PhysicalNestedLoopJoin<LEFT_CHILD_TYPE, RIGHT_CHILD_TYPE> withPhysicalPro hashJoinConjuncts, otherJoinConjuncts, Optional.empty(), getLogicalProperties(), physicalProperties, statsDeriveResult, left(), right()); } + + public void addBitmapRuntimeFilterCondition(Expression expr) { + bitMapRuntimeFilterConditions.add(expr); + } + + public boolean isBitmapRuntimeFilterCondition(Expression expr) { + return bitMapRuntimeFilterConditions.contains(expr); + } + + public boolean isBitMapRuntimeFilterConditionsEmpty() { + return bitMapRuntimeFilterConditions.isEmpty(); + } Review Comment: currently, BE only support BitmapRF in nested loop join. if subquery is correlation, and in-predicate is " int in (select Bitmap_col ...)", original planner report error :" In bitmap does not support correlated subquery" I will add a check to get inline with original planner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org