github-actions[bot] commented on code in PR #17246:
URL: https://github.com/apache/doris/pull/17246#discussion_r1121376869
##########
be/test/olap/tablet_cooldown_test.cpp:
##########
@@ -24,6 +24,8 @@
#include "exec/tablet_info.h"
#include "gen_cpp/internal_service.pb.h"
#include "io/fs/s3_file_system.h"
+#include "io/fs/remote_file_system.h"
+#include "io/fs/remote_file_system_mock.h"
Review Comment:
warning: 'io/fs/remote_file_system_mock.h' file not found
[clang-diagnostic-error]
```cpp
#include "io/fs/remote_file_system_mock.h"
^
```
##########
be/test/olap/tablet_cooldown_test.cpp:
##########
@@ -41,21 +43,75 @@
static constexpr int64_t kResourceId = 10000;
static constexpr int64_t kStoragePolicyId = 10002;
+class RemoteFileSystemMock : public io::RemoteFileSystem {
+ RemoteFileSystemMock(Path&& root_path, std::string&& id, FileSystemType
type)
+ : RemoteFileSystem(std::move(root_path), std::move(id), type) {}
+ ~RemoteFileSystemMock() override {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
~RemoteFileSystemMock() override = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
