cambyzju commented on code in PR #17252:
URL: https://github.com/apache/doris/pull/17252#discussion_r1121232780


##########
be/src/olap/tablet.cpp:
##########
@@ -1642,7 +1642,7 @@ void 
Tablet::_init_context_common_fields(RowsetWriterContext& context) {
 }
 
 Status Tablet::create_rowset(const RowsetMetaSharedPtr& rowset_meta, 
RowsetSharedPtr* rowset) {
-    return RowsetFactory::create_rowset(tablet_schema(), tablet_path(), 
rowset_meta, rowset);
+    return RowsetFactory::create_rowset(_schema, tablet_path(), rowset_meta, 
rowset);

Review Comment:
   should use _max_version_schema?
   
   ```
   TabletSchemaSPtr Tablet::tablet_schema() const {
       std::shared_lock wrlock(_meta_lock);
       return _max_version_schema;
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to