TangSiyang2001 commented on PR #17249: URL: https://github.com/apache/doris/pull/17249#issuecomment-1449333553
Hi @SaintBacchus , just for disscussion, how about replace the ConnectContext#resetExecTimeout by ``` java public void setExecTimeout(int timeout) { executionTimeoutS = timeout; } ``` And in StmtExecutor#handleInsertStmt, use ```java context.setExecTimeout(Math.max(context.getSessionVariable().getInsertTimeoutS(), context.getExecTimeoutS())); ``` I think it may seem clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org