nextdreamblue commented on code in PR #17190: URL: https://github.com/apache/doris/pull/17190#discussion_r1121062378
########## be/src/olap/null_predicate.h: ########## @@ -54,10 +54,13 @@ class NullPredicate : public ColumnPredicate { } bool evaluate_del(const std::pair<WrapperField*, WrapperField*>& statistic) const override { + // evaluate_del only use for delete condition to filter page, need use delete condition origin value, + // when opposite==true, origin value 'is null'->'is not null' and 'is not null'->'is null', Review Comment: only deletehandler set opposite=true, when opposite==false, 'is null' is 'is null' and 'is not null' is 'is not null'. and evaluate_del only use for delete condition to filter page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org