github-actions[bot] commented on code in PR #17244:
URL: https://github.com/apache/doris/pull/17244#discussion_r1119915658
##########
be/src/io/hdfs_builder.h:
##########
@@ -31,13 +31,20 @@ const std::string KERBEROS_KEYTAB =
"hadoop.kerberos.keytab";
const std::string TICKET_CACHE_PATH = "/tmp/krb5cc_doris_";
class HDFSCommonBuilder {
- friend HDFSCommonBuilder createHDFSBuilder(const THdfsParams& hdfsParams);
- friend HDFSCommonBuilder createHDFSBuilder(
- const std::map<std::string, std::string>& properties);
+ friend Status createHDFSBuilder(const THdfsParams& hdfsParams,
HDFSCommonBuilder* builder);
+ friend Status createHDFSBuilder(const std::map<std::string, std::string>&
properties,
+ HDFSCommonBuilder* builder);
public:
- HDFSCommonBuilder() : hdfs_builder(hdfsNewBuilder()) {}
- ~HDFSCommonBuilder() { hdfsFreeBuilder(hdfs_builder); }
+ HDFSCommonBuilder() {}
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
```suggestion
HDFSCommonBuilder() = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
