TangSiyang2001 opened a new issue, #17158: URL: https://github.com/apache/doris/issues/17158
### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description As konwn, we can specify a helper node by --helper param, however the logic in Env.java seems incorrect. ```java private void getHelperNodes(String[] args) throws Exception { String helpers = null; for (int i = 0; i < args.length; i++) { if (args[i].equalsIgnoreCase("-helper")) { // FIXME: we could not reach here because `-helper` is invalid param, and it should be replaced by `--helper` if (i + 1 >= args.length) { throw new AnalysisException("-helper need parameter host:port,host:port"); } helpers = args[i + 1]; break; } } if (!Config.enable_deploy_manager.equalsIgnoreCase("disable")) { ... } else { if (helpers != null) { // FIXME: we could not reach here cause helper node must be null String[] splittedHelpers = helpers.split(","); for (String helper : splittedHelpers) { Pair<String, Integer> helperHostPort = SystemInfoService.validateHostAndPort(helper); if (helperHostPort.equals(selfNode)) { throw new AnalysisException("Do not specify the helper node to FE itself. " + "Please specify it to the existing running Master or Follower FE"); } helperNodes.add(helperHostPort); } } else { // FIXME: so we fallthrough to here and use self node as the helper node // If helper node is not designated, use local node as helper node. helperNodes.add(Pair.of(selfNode.first, Config.edit_log_port)); } } LOG.info("get helper nodes: {}", helperNodes); } ``` ### Solution Modify `if (args[i].equalsIgnoreCase("-helper"))` to `if (args[i].equalsIgnoreCase("--helper")` simply and effectively. ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
