924060929 commented on PR #70398: URL: https://github.com/apache/doris/pull/70398#issuecomment-6848529915
### Local CI repair review — validated locally Commit: `742a21e1d2d365dcf344f57e56ac1704c34e63ba` (branch-4.2). The regression warms three base-table SQL caches before creating synchronous MVs. `RollupJobV2.onFinished` publishes the rollup, rebuilds the table schema and calls `Env.onTableChanged`; invalidating those caches is intended. [P0 build 3344](https://8.218.164.131/buildConfiguration/Doris_P0/3344) still expected the old cache entries to survive, causing the `mv_with_sql_cache` failure. The repair uses one shared assertion in all three create-MV scenarios: require cache misses after publication, execute the same queries again, then require cache hits. Later rename, insert and drop checks are preserved. Only this regression script changes; no production or golden-result changes. Validation: - `./run-fe-ut.sh --run org.apache.doris.alter.RollupJobV2Test,org.apache.doris.qe.TableCacheInvalidationTest`: **40 tests passed**, zero failures/errors/skips. The rollup test explicitly verifies eviction of a cache populated while the shadow index is invisible. - `./build.sh --fe`: passed, including Checkstyle (UI disabled). - `./run-regression-test.sh --compile`: passed. The modified suite compiled with this worktree's regression framework classpath. - `git diff --check`: passed. One clean solo review round of the repair diff and its production call chain; no actionable findings. This is a focused repair review, not a fresh full-PR review. - End-to-end regression was **not** run locally because this isolated worktree has no BE binary. The next CI run must verify the repaired suite. Other failures remain separate and are **not claimed fixed**: - [NonConcurrent 3348](https://8.218.164.131/buildConfiguration/Doris_NonConcurrent/3348): `sparse_ancestor_promotion_extended` expected row 6 to retain `{"p":{"a":[]}}`, but received `{}`. The failing query is the first result query on that newly created/updated MoW table. The suite comes from target-branch commit `b6b9ea8b2f2` / #70356 (BE sparse-cell handling). Its relationship to this FE cache PR is unproven; a target-baseline comparison is still needed. - The cold-data compaction case did not finish before the runner's **5,400-second** limit. The log establishes the deadline termination, not the underlying reason for slow/stalled compaction. - Previously muted compaction/SNII failures and the [external 3347 infrastructure prerequisite](https://github.com/apache/doris/pull/70398#issuecomment-6844954325) are unchanged. Remote gates will be triggered for this commit; no all-green or merge-readiness claim. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
