Gabriel39 opened a new pull request, #70545:
URL: https://github.com/apache/doris/pull/70545

   ### Background
   
   BE runtime statistics arrive asynchronously, so FE audit logging waits for 
final reports from the backends that received fragment dispatch attempts. The 
current implementation already supports generic participant tracking but also 
retains a separate coordinator and executor classification for external writes.
   
   ### What problem does this PR solve?
   
   Issue Number: None
   Related PR: #67053 (introduced external-write-specific audit tracking)
   PR Type: Refactor
   
   Problem Summary:
   
   Remove the external-DML-specific audit state, accessors, and executor-type 
checks. Table inserts use their existing shared execution coordinator, and 
FILES inserts publish their coordinator through the same statement execution 
state. Audit participants come from dispatched backend IDs and the existing 
query-scoped failure snapshot.
   
   ### Details
   
   - **Moves vs. logic changes:** Remove the duplicate external-write 
coordinator registration and classification helper. Rename the scheduler 
participant accessor to `getDispatchedBackendIds()` and update its callers and 
tests.
   - **Behavior change:** FILES inserts publish the execution coordinator 
through `StmtExecutor.setCoord()`, sharing the existing audit and cancellation 
handoff. Participant selection, final-report waiting, timeout fallback, and 
failure snapshots retain their existing rules.
   - **Compatibility:** No Thrift field IDs, types, or optionality change; the 
forwarding-field edit only updates its comment. No storage format changes.
   - **Performance impact:** Remove an extra retained coordinator reference and 
an extra participant source. No additional threads, locks, queues, or waits.
   - **Rollback:** Revert this PR; no migration is required.
   
   ### Testing
   
   - Locally ran `run-fe-ut.sh --run` for eight suites: 
`AuditLogHelperBackendSelectionTest`, `MasterOpExecutorBackendSelectionTest`, 
`PipelineExecutionTaskTest`, `WorkloadRuntimeStatusMgrTest`, 
`InsertIntoTableCommandTest`, `InsertIntoTVFCommandTest`, 
`OlapInsertExecutorTest`, and `StreamingInsertTaskAuditTest`: 76 tests passed, 
with no failures, errors, or skips.
   - The two new FILES command tests failed before the change because the 
standard coordinator was absent. Both now pass and cover successful execution, 
partial dispatch failure, retained participants, and coordinator cleanup.
   - FE Checkstyle: zero violations.
   - `git diff --check`: passed.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Behavior changed: Yes (see Details)
   - Does this need documentation: No
   - Pre-submission status: Ready
   
   ### AI Disclosure
   
   - Tool: Codex (GPT-6)
   - Generated: Code changes, tests, and this description.
   - Human review: Pending.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to