sollhui commented on PR #69605: URL: https://github.com/apache/doris/pull/69605#issuecomment-6762818032
Could we rename `S3FileSystem` to `ObjStorageFileSystem`? With `refresh_resource()`, the same file system instance can switch from an S3 client to a native Azure Blob client. Seeing `S3FileSystem` at a call site suggests S3 protocol semantics that the class doesn't always provide. `ObjStorageFileSystem` would also match `ObjStorageClient` and `ObjStorageConfig`. I'm happy for the rename to be a follow-up if it would add too much churn here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
