guptashivam04 commented on PR #70302: URL: https://github.com/apache/doris/pull/70302#issuecomment-6761074106
Thanks for catching this, you're right. check_function puts every row of the dataset into the Consted column, and ColumnConst only accepts one. Fixed in a8f3d866de: both const polygon tests now build the constant from a one-row column, the same way the across-blocks test does. The cases they check are unchanged. This time I ran them locally (ASAN build with the geo tests): - the new tests pass, with and without the source change, since results are the same - the old version fails with exactly the error you described - if the cache stops checking whether the constant changed, the across-blocks test fails Could you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
