deardeng commented on PR #70006:
URL: https://github.com/apache/doris/pull/70006#issuecomment-6758093134
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70006
commit: 833a723001783d559b2abd8248ad2ac7b98ab2cc
base: 3763f0989794c14906e56757eb975d314918697a
reviewed_at: 2026-11-10T11:25+08:00
reviewer: deardeng
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 1, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- F-01 (Minor, observability; not a new regression),
`cloud/src/meta-service/meta_service_helper.h:363-370`: the GetInstance RPC log
copy clears node credentials but retains the four sensitive cluster-property
aliases already scrubbed by ResourceManager::update_cluster. Reuse the same
log-only cleanup and cover the direct RPC in a test; response/persistence must
remain unchanged.
- This was a static review on devbtt: all 12 changed files covered; no
builds or tests run. HTTP DEBUG retaining full request details is explicitly
declared by the head commit and is not a claim of comprehensive redaction.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
