yiguolei commented on PR #70190:
URL: https://github.com/apache/doris/pull/70190#issuecomment-6626848887
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70190
commit: 002f538a7b8f91050784e170203455e1af940efe
base: 0eb5131db62cd7939788508377fc148df6ac1ef1
reviewed_at: 2026-11-04T16:59+08:00
reviewer: yiguolei
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/catalog/TokenManager.java:66-175` —
The prior local review's three Major trigger sequences are repaired: restore
the full current cache, retain at least four generations, and reconcile RPC
completion with promotion/superseding acquisitions.
- `be/src/service/arrow_flight/flight_sql_service.cpp:134-146` — Review
assumes verification off, upgrade all BEs then all FEs, distribute keys/finish
unsigned tickets, then restart BEs to enable verification. The explicitly
accepted absent/stale follower-cache limitation remains.
- Source review covered 23/23 changed files and converged in round 1.
Builds, tests and live failover were not run; CI results were unavailable
because the check-runs request failed with EOF.
- `gensrc/thrift/FrontendService.thrift:1007-1013` and
`gensrc/thrift/HeartbeatService.thrift:54-59` — No id collision in the complete
definitions at the recorded local release-branch SHAs; remote freshness checks
failed with TLS/EOF.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
