raghav-reglobe commented on PR #70349:
URL: https://github.com/apache/doris/pull/70349#issuecomment-6682249927
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70349
commit: 5158d9ffce8fecab6e6088656d6792b840f50ca3
base: 4c63661f60f96c694757000640bcebc832e8bb6d
reviewed_at: 2026-11-06T15:31+05:30
reviewer: raghav-reglobe
model: claude-fable-5-1
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 3}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Auth.java:2324-2332`
— the row is sized from `MysqlDBTable`'s schema and the FE asserts that the
table ends with exactly `PasswordPolicy.MYSQL_USER_COLUMNS`; the BE's
`SchemaUserScanner` list (the third copy, positional) is pinned by the new
`auth_p0` suite rather than by that assertion.
- `be/src/information_schema/schema_user_scanner.cpp:65` — mixed versions: a
new BE fills the column empty from an old FE's rows; an old BE cannot serve the
new column to a new FE (`SELECT *` from `mysql.user` fails with `no match
column` until that BE is upgraded), as for any schema-table column.
- Every expected value in `AccountLockTest` and the suite was re-derived
from the code (`2592000` = 30 days, `86400` = 1 day, `""` for an unset lock
time, `***` for the masked history).
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
