deardeng commented on PR #70320:
URL: https://github.com/apache/doris/pull/70320#issuecomment-6676557845
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70320
commit: a76eba0f333b47eabfa821b16019eb0706262c7a
base: 87b462e4f58104140f098f5f4a8b5d58bec70149
reviewed_at: 2026-11-06T12:04+08:00
reviewer: deardeng
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/catalog/HdfsStorageVault.java:189-191`
— CREATE and ALTER preserve the canonical Kerberos mode through the existing
Meta Service and BE paths.
-
`fe/fe-core/src/test/java/org/apache/doris/cloud/catalog/HdfsStorageVaultTest.java:68-81`
— the real-serializer test detects the omitted entry and wrong key/value case;
this review did not execute builds, tests or live Kerberos I/O.
- Existing affected vaults require ALTER with authentication=kerberos,
principal and keytab after the fixed FE is deployed.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
