raghav-reglobe commented on PR #70371:
URL: https://github.com/apache/doris/pull/70371#issuecomment-6711425964
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70371
commit: 0837967e1ff41376879360c433d272f47c348d0f
base: 41cd2b473e9d9bb26be089f302cdfdfe6e107eaf
reviewed_at: 2026-11-08T00:06+05:30
reviewer: raghav-reglobe
model: claude-fable-5-1
effort: xhigh
findings: {blocker: 0, major: 0, minor: 1, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/SetPassVarOp.java:75-78`
— mixed-fleet note (Minor, documentation): `SET PASSWORD FOR` forwards to the
master, and `SetOptionsCommand.afterForwardToMaster` re-runs `validate` on the
follower; during a rolling upgrade an already-upgraded follower reports a
grant_priv-only `SET PASSWORD FOR <other>` as refused after a not-yet-upgraded
master has applied it under the old rule. The reverse pairing is clean; `ALTER
USER` and `GRANT role` have no such hook.
-
`fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/commands/GrantRoleScopeTest.java:123-135`
— the storage-vault case pins both the role path and the direct `GRANT … ON
STORAGE VAULT` path; the base and a routing back to the general resource table
fail its positive steps.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
