github-actions[bot] commented on code in PR #69995:
URL: https://github.com/apache/doris/pull/69995#discussion_r4499322562
##########
fe/fe-core/src/main/java/org/apache/doris/task/CreateReplicaTask.java:
##########
@@ -139,6 +139,7 @@ public class CreateReplicaTask extends AgentTask {
private Map<Object, Object> objectPool;
private List<Integer> rowStoreColumnUniqueIds;
+ private final boolean variantEscapeDotsInKeys;
Review Comment:
[P1] Gate escaped Variant tables during rolling upgrades
`CreateReplicaTask` now sends `variant_escape_dots_in_keys` only through the
new optional Thrift field. An older BE ignores that field, persists the tablet
with the default false policy, and writes segments without
`variant_path_encoding=1`, while the FE and newer BEs query the same table
using escaped paths. For example, `{"a.b":1,"a":{"b":2}}` written on an old
replica is flattened and cannot be recovered as two keys, so mixed replicas
return different Variant values. Reject or gate creation/writes of this
property until all target BEs support the codec, or add a compatibility path
that preserves the per-replica encoding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
