morningman commented on PR #70093: URL: https://github.com/apache/doris/pull/70093#issuecomment-6621370771
Closing this PR because we no longer intend to support scan plans generated by old FEs. The substantive fix extends the fallback guarded by `!supports_iceberg_scan_semantics_v2(...)`. Current FE plans explicitly advertise scan semantics v2 and supply schema metadata for the applicable equality-delete keys, including historical fields, so they do not need this fallback. The other production changes propagate the full delete-file name path while preserving the existing leaf-name behavior. The two missing-key NULL test matrices have some independent coverage value, but they currently construct old-FE plans. That coverage can be added separately using current scan semantics, complete key/ancestor schema metadata, and appropriate name mappings for ID-less files. It does not require retaining this compatibility fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
