suxiaogang223 commented on PR #69886:
URL: https://github.com/apache/doris/pull/69886#issuecomment-6652513570
Local review with the Doris `code-review` skill: **PASS** for
`4078a16c9b67a4467275f2dfc31e125eba4a42d1` against
`913532ce1673595cd552bd6f582e5b2640f45dd9`. No unresolved findings.
Reviewed the Rust/JNI selection, shared pinned descriptor, v14 commit
transport, memory admission/release, report ownership and FE commit/rollback
flow. The six feature patches are unchanged by the rebase.
Current-head CI compilation, FE UT and Cloud UT have passed. BE UT and
regression jobs are still running. This review does not mark unfinished tests
as passed. Earlier local validation covered 164 related BE tests (20 FFI writer
tests) and 1,541 FE/Java tests (one skip); those were not rerun during this
review. Local formatting with clang-format 16, build hygiene, shell syntax and
cross-release Thrift checks passed.
<details>
<summary>Doris skill checkpoints</summary>
| Checkpoint | Conclusion |
| --- | --- |
| Goal | Supported append writes prefer Rust; unsupported writes select JNI
before consuming input. |
| Scope and reuse | Changes reuse the existing transaction/report framework
and pinned table schema. |
| Concurrency and locks | Per-task writer calls are serialized; admission
locks exclude SDK work and group refresh; abort I/O runs outside the connector
state lock. |
| Lifetime and static initialization | Native work stops before writer
credit/slots are returned; report callbacks own their metadata and tracker;
metrics initialize lazily. |
| Online settings | Mutable limits apply to new admissions; active budgets
retain their original value. |
| Compatibility | Missing descriptors, unsupported commit versions and JNI
ABI mismatches return errors, consistent with the agreed mixed-version scope. |
| Thrift/Proto | Checked master and branches 3.1/4.0/4.1/4.2: optional
additions, stable meanings and no ID collisions. No protobuf changes. |
| Parallel paths | Descriptor sharing covers Rust reads and Rust/JNI writes;
SPI forwarding and S3/MinIO aliases are complete. |
| Conditions | Backend eligibility and cleanup states correspond to concrete
supported/failed paths; runtime errors fail the statement. |
| Coverage | Tests cover budgets, release, cancellation, prepare/report
failures, protocol bytes and FE outcomes; current CI remains in progress. |
| Test results | Real writer fixtures verify Java interoperability;
generated regression outputs were not edited. |
| Observability | Profiles/metrics cover selection, resources, input,
timing, failures and transaction states. |
| Transactions and persistence | FE alone publishes snapshots;
pre-publication failures clean up, uncertain outcomes retry/reconcile and
preserve files. No new EditLog. |
| Data writes and crashes | BE only prepares; ACK/rejection/ambiguous
ownership is handled explicitly. Crash/cleanup-I/O orphan maintenance remains
an accepted limitation. |
| FE/BE propagation | Session forwarding, sink/scan descriptors and commit
version agree; JNI rebuilds the pinned table. |
| Performance and memory | Input/commit payloads are bounded; query/native
credits are estimates. Full RSS limits, spill and revocation remain outside
scope. |
| Other integration | Checked current Coordinator/profile lifetime,
transaction-manager behavior, SPI version and plugin dependencies; master
includes the common BE UT build fix #70209. |
</details>
<!-- doris-repo-review:v1:begin -->
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69886
commit: 4078a16c9b67a4467275f2dfc31e125eba4a42d1
base: 913532ce1673595cd552bd6f582e5b2640f45dd9
reviewed_at: 2026-11-05T07:37:01+00:00
reviewer: suxiaogang223
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
