mrhhsg commented on PR #70211:
URL: https://github.com/apache/doris/pull/70211#issuecomment-6649882010
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70211
commit: 4ee42e543a4ccd232a68fcbbc5d1f7a8e9f17066
base: 7ff8c69da8ffb2907a9d3a9adcbe5564fd13308d
reviewed_at: 2026-11-05T12:42+08:00
reviewer: mrhhsg
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- `be/src/exprs/vbloom_predicate.cpp:227-255`：已静态核对
owner/generation/child-seed 缓存与旧 digest 语义；稳定并发 reader 受 mutex/call_once
保护，generation 不提供并发 payload mutation/probing 保证。
- `be/test/exprs/vbloom_predicate_digest_test.cpp:101-270`：8
个新增单测覆盖复用计数、clone/child 重绑、替换与 alias mutation；本轮审查未执行构建或测试，不代表 CI、混部或性能验证通过。
-
`regression-test/suites/query_p0/cache/test_bloom_predicate_digest_cache.groovy:19-85`：新增
SQL 是内表正确性回归，没有实际 cache-hit 断言或外表多 split E2E；未独立验证端到端延迟收益。
- 作者描述披露 focused UT build 曾临时排除并恢复未修改的 vparquet_writer_test.cpp；报告的 focused
UT 通过不等于完整 UT suite 通过，本轮没有重新运行验证。
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
