github-actions[bot] commented on code in PR #70246:
URL: https://github.com/apache/doris/pull/70246#discussion_r4476956158
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergScanPlanProvider.java:
##########
@@ -1878,6 +1879,7 @@ private IcebergScanRange buildRange(Table table, Schema
scanSchema, DataFile dat
.length(task.length())
.fileSize(dataFile.fileSizeInBytes())
.fileFormat(file.fileFormat)
Review Comment:
[P1] Do not collapse a mixed encrypted snapshot into an unmarked COUNT
range. COUNT planning chooses one representative task and calls `buildRange`
once, so this new carrier describes only that file. When the representative is
plaintext but a later data file has `keyMetadata`, the aggregate metadata COUNT
bypasses the per-file descriptor/BE guard and succeeds without rejecting the
encrypted file. Disable metadata COUNT (or inspect and reject every task)
whenever any file carries encryption metadata.
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergScanRange.java:
##########
@@ -415,6 +417,9 @@ public void populateRangeParams(TTableFormatFileDesc
formatDesc, TFileRangeDesc
return;
}
fileDesc.setFormatVersion(formatVersion);
Review Comment:
[P1] Preserve or reject delete-file encryption metadata. The new
`encryption_info` is populated only on the outer data descriptor;
`convertDelete`/`DeleteFile.toThrift()` still omit each
`DeleteFile.keyMetadata()`. A table with plaintext data and an independently
encrypted position/equality delete therefore sends the delete descriptor
without field 12, so the BE has no key source and opens it as plaintext (or
applies the wrong rows). Populate the existing per-delete field or fail closed
before emitting the range.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
