github-actions[bot] commented on code in PR #70168:
URL: https://github.com/apache/doris/pull/70168#discussion_r4475853883
##########
regression-test/suites/tpcds_sf1_unique_p1/spill/q24_1.groovy:
##########
@@ -52,7 +52,7 @@ WITH
AND (ss_item_sk = i_item_sk)
AND (ss_store_sk = s_store_sk)
AND (c_current_addr_sk = ca_address_sk)
- AND (c_birth_country = upper(ca_country))
Review Comment:
[P2] Update or justify the remaining SF1000 q24 copies. This change corrects
the stale equality predicate in the SF1 spill copies, but
`regression-test/suites/tpcds_sf1000_p2/sql/q24_{1,2}.sql:28` still uses
`c_birth_country = upper(ca_country)` and retains the old seven/one-row
baselines. The canonical SF1000 q24 template and every other q24 variant use
`<>` after the current-address join. Please apply the same correction and
regenerate those outputs, or document why this active parallel path
intentionally remains different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
