github-actions[bot] commented on code in PR #70312:
URL: https://github.com/apache/doris/pull/70312#discussion_r4488579045
##########
regression-test/suites/compaction/test_base_compaction_no_value.groovy:
##########
@@ -81,6 +81,7 @@ suite("test_base_compaction_no_value", "p2") {
file """${getS3Url()}/regression/tpch/sf1/lineitem.csv.split01.gz"""
time 10000 // limit inflight 10s
+ retryIfHttpError true
Review Comment:
[P1] Reject a non-ranged response before enabling this retry path. On a
reopen with `startOffset > 0`, `openNewStream` currently accepts `200 OK` and
any `206` without checking `Content-Range`, then sets `offset` to the requested
offset. If the S3 endpoint or a proxy ignores or misreports `Range`, the reader
appends bytes from the beginning (or another range) after the prefix already
consumed, so these stream-load tests can load duplicate or corrupt input while
checks that only compare `NumberTotalRows` with `NumberLoadedRows` still pass.
Require `206` with a matching range start, and accept `200` only for the
initial request, before consuming the entity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
