Gabriel39 commented on PR #70079:
URL: https://github.com/apache/doris/pull/70079#issuecomment-6620740994
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70079
commit: 79b0eb0d7ba93ca9a2801b47a2ed68d59a6a2a11
base: c8a75b273e999370e354ed39ae65db2c483c0ad0
reviewed_at: 2026-11-04T10:17+08:00
reviewer: Gabriel39
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 1, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- F-01 (test-coverage, Regression: yes, Minor)
`regression-test/suites/external_table_p0/tvf/test_orc_condition_cache_seek.groovy:66`:
the new N+1 scan limit can falsely fail a correct reader when a full
condition-cache shard needs two LRU-K admission misses before a hit. With one
backend, scans 1 and 2 miss and scan 3 hits; allow two admission visits per
backend (2*N+1 with stable cache contents). This affects test reliability, with
no demonstrated production correctness regression.
- The ORC pin's exact/partial stripe-suffix transition, split bounds, EOF
and lazy follower state were reviewed against the previous pin. All five
changed files were covered. This was a static review; builds, BE/ORC/SQL tests
and benchmarks were not executed.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
