OIiveirra commented on code in PR #69032:
URL: https://github.com/apache/doris/pull/69032#discussion_r4430879904
##########
gensrc/thrift/Types.thrift:
##########
@@ -104,7 +104,10 @@ enum TPrimitiveType {
VARBINARY = 43, // represent varbinary type
TIMESTAMPTZ = 44, // timestamp with time zone
TIMESTAMP_NS = 45, // signed nanoseconds since the Unix epoch
- UUID = 46
+ UUID = 46,
+ // 47 is FILE in branch-4.1; keep its wire identity reserved.
+ GEOMETRY = 48,
Review Comment:
As confirmed by Gabriel39 in [the scope
decision](https://github.com/apache/doris/pull/69032#discussion_r4326385148),
mixed 4.x/5.0 execution compatibility is outside this PR. Participating FE/BE
nodes must support spatial types, as documented in the PR. The recursive remote
constant-folding protection remains; the removed capability/heartbeat gate is
not restored.
Commit:
[ec7c88263491](https://github.com/apache/doris/commit/ec7c88263491d67470584e7e361330567c730b65).
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/MapAggV2.java:
##########
@@ -18,6 +18,7 @@
package org.apache.doris.nereids.trees.expressions.functions.agg;
import org.apache.doris.catalog.FunctionSignature;
+import org.apache.doris.nereids.exceptions.AnalysisException;
import org.apache.doris.nereids.trees.expressions.Expression;
import
org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature;
Review Comment:
Fixed by recursively checking only the MAP_AGG key for spatial leaves. Added
Array/Map/Struct scan, planner and state-entry regressions for both kinds.
Ordinary-key/spatial-value support is preserved.
Commit:
[ec7c88263491](https://github.com/apache/doris/commit/ec7c88263491d67470584e7e361330567c730b65).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
