OIiveirra commented on code in PR #69032:
URL: https://github.com/apache/doris/pull/69032#discussion_r4420645495
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/ConnectorChangelogPlanBuilder.java:
##########
@@ -207,6 +208,7 @@ private static ExpressionAnalyzer analyzer(LogicalPlan
plan, CascadesContext con
private static Alias bindColumn(ExpressionAnalyzer analyzer, Expression
expression, Column column) {
Expression value = analyzer.analyze(expression);
Review Comment:
Fixed in 5522619. Changelog UPDATE and MERGE now normalize proven nested
spatial NULLs before validation and casting. Added regression coverage for
ARRAY<GEOMETRY> NULL in both paths.
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergConnectorMetadata.java:
##########
@@ -1146,6 +1146,15 @@ public void createTable(ConnectorSession session,
ConnectorCreateTableRequest re
rejectReservedRowLineageColumns(request);
validateSortOrder(request);
Schema schema = IcebergSchemaBuilder.buildSchema(request.getColumns());
+ boolean spatial = false;
+ for (Types.NestedField field : schema.columns()) {
+ spatial |=
IcebergSpatialSchemaValidator.containsSpatial(field.type());
+ }
+ if (spatial) {
+ IcebergSpatialSchemaValidator.validateTable(
Review Comment:
Fixed in 5522619. ALTER TABLE SET PROPERTIES now validates the effective
format/version against existing spatial schemas, rejecting non-Parquet or
pre-V3 updates. Added ORC rejection and Parquet acceptance regression coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
