yinzhijian commented on code in PR #16980:
URL: https://github.com/apache/doris/pull/16980#discussion_r1113098906
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/NereidsPlanner.java:
##########
@@ -200,6 +215,33 @@ private void analyze() {
cascadesContext.newAnalyzer().analyze();
}
+ private void cache() {
+ ConnectContext connectContext = cascadesContext.getConnectContext();
+ boolean isEnableSqlCache =
connectContext.getSessionVariable().isEnableSqlCache();
+ boolean isEnablePartitionCache =
connectContext.getSessionVariable().isEnablePartitionCache();
+ CacheContext cacheContext =
cascadesContext.getStatementContext().getCacheContext();
+ Plan plan = cascadesContext.getMemo().copyOut(false);
+ if (!isEnableSqlCache && !isEnablePartitionCache) {
Review Comment:
**check Config.cache_enable_sql_mode && Config.cache_enable_partition_mode**
see CacheAnalyzer.checkCacheConfig.
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -1195,10 +1218,16 @@ private void handleQueryStmt() throws Exception {
boolean isOutfileQuery = queryStmt.hasOutFileClause();
// Sql and PartitionCache
- CacheAnalyzer cacheAnalyzer = new CacheAnalyzer(context, parsedStmt,
planner);
- if (cacheAnalyzer.enableCache() && !isOutfileQuery && queryStmt
instanceof SelectStmt) {
- handleCacheStmt(cacheAnalyzer, channel, (SelectStmt) queryStmt);
+ if (queryStmt instanceof LogicalPlanAdapter) {
+ CacheAnalyzer cacheAnalyzer = new CacheAnalyzer(context,
parsedStmt, (NereidsPlanner) planner);
+ handleCacheAdapter(cacheAnalyzer, channel);
Review Comment:
Why is enableCache not checked here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]