morningman commented on PR #69711: URL: https://github.com/apache/doris/pull/69711#issuecomment-6484286455
Addressed the fourth review round in 0d70d8c3718. - P2, a STRING-placeholder `timestamptz_ns` default compared to microsecond tombstones (r4401112878): fixed by failing the split with `NotSupported` again for a non-NULL `timestamptz_ns` default of a key the data file does not store. V2 reads such tombstones as `TIMESTAMPTZ(6)` (Parquet floors the nanoseconds, ORC rounds them), so no parse of the default compares exactly; the third round's parsing could delete every row of an older file for a tombstone 100 ns after the default. TIME defaults, which are exact in microseconds, are still parsed; NULL defaults and stored keys are unchanged. New BE UT `IcebergMissingPlaceholderTimestampTzNsDefaultFailsTheScan`. The description is updated to match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
