OIiveirra commented on code in PR #69032:
URL: https://github.com/apache/doris/pull/69032#discussion_r4386271164
##########
gensrc/proto/types.proto:
##########
@@ -124,6 +128,8 @@ message PGenericType {
TIMESTAMPTZ = 42;
TIMESTAMP_NS = 43;
UUID = 44;
+ GEOMETRY = 45;
Review Comment:
Fixed in f02598ba88e. Reserved branch-4.1 FILE protobuf 45 / Thrift 47 and
moved Geometry/Geography to 46/47 and 48/49. Added fixed-ID and actual
FILE-metadata rejection tests; final type tests pass 18/18.
##########
fe/fe-connector/fe-connector-spi/src/main/java/org/apache/doris/connector/spi/ConnectorCapability.java:
##########
@@ -304,5 +304,13 @@ public enum ConnectorCapability {
* data tables while declining it on the subset of system tables whose
readers cannot observe a
* selected snapshot.</p>
*/
- SUPPORTS_SCAN_PARAM_OPTIONS
+ SUPPORTS_SCAN_PARAM_OPTIONS,
+ /**
+ * Admits spatial leaves inside ARRAY elements, MAP values and STRUCT
fields in column DDL.
+ * The connector still validates table format/version and spatial identity
before mutations.
+ *
+ * <p><b>Scope: catalog-wide only.</b> CREATE needs this answer before the
target table exists.
+ * This does not admit spatial MAP keys, Variant fields, or Doris
internal-table storage.</p>
+ */
+ SUPPORTS_NESTED_SPATIAL_TYPES
Review Comment:
Fixed in f02598ba88e. Bumped the spatial connector API to 24.0 and updated
the version pin. SPI/API gate and wiring tests pass 194/194; the FE resource
and all ten current connector entrypoint manifests advertise 24.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
