github-actions[bot] commented on code in PR #69629:
URL: https://github.com/apache/doris/pull/69629#discussion_r4384955655
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergExternalTable.java:
##########
@@ -366,8 +379,10 @@ public Map<String, SysTable> getSupportedSysTables() {
@Override
public boolean isView() {
- makeSureInitialized();
- return isView;
+ return withMissingTableRepair(() -> {
Review Comment:
[P2] Guard the live Iceberg view-text read
On a REST catalog with `meta.cache.iceberg.view.ttl-second=0`, warm `SHOW
TABLES` and `SHOW CREATE TABLE ctl.db.v`, drop the view remotely, then run
SELECT or SHOW CREATE first. The retained `isView=true` makes this guard return
successfully; `loadSnapshot()` likewise returns `EmptyMvccSnapshot` without
loading the view. Binding then reaches `BindRelation.getLogicalPlan()` ->
`getViewText()`, while SHOW CREATE reaches `IcebergUtils.showCreateView()` ->
`getViewText()`. That method calls `IcebergUtils.getIcebergView()` outside
every repair guard, so the preserved `NoSuchViewException` never triggers
lookup repair. Names/object/ID remain stale across repeated requests. Guard the
live view-load/text boundary and add SELECT-first and SHOW-CREATE-first
dropped-view cases. This is distinct from thread 4384658707: its
STATUS/properties path now reaches the classifier correctly; this text-read
path never enters it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
