924060929 commented on code in PR #69632:
URL: https://github.com/apache/doris/pull/69632#discussion_r4376590611
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonExternalTable.java:
##########
@@ -403,7 +403,10 @@ public boolean isPartitionColumnAllowNull() {
@Override
public MvccSnapshot loadSnapshot(Optional<TableSnapshot> tableSnapshot,
Optional<TableScanParams> scanParams) {
- return new
PaimonMvccSnapshot(getPaimonSnapshotCacheValue(tableSnapshot, scanParams));
+ return withMissingTableRepair(() -> {
Review Comment:
Fixed in 67c364208a9. Both loadLatestSnapshotFence() and the fenced
loadSnapshot() overload use guarded missing-table repair. The OPTIONS-first
test enters StatementContext.loadSnapshots(), raises TableNotExistException
during fence acquisition and verifies repair before propagating the original
failure.
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergExternalTable.java:
##########
@@ -276,12 +281,18 @@ protected boolean needInternalHiddenColumns() {
@Override
public List<Column> getFullSchema() {
- return getFullSchema(MvccUtil.getSnapshotFromContext(this));
+ return withMissingTableRepair(() -> {
+ return getFullSchema(MvccUtil.getSnapshotFromContext(this));
+
+ });
}
@Override
public List<Column> getFullSchema(Optional<MvccSnapshot> snapshot) {
- return IcebergUtils.withSnapshotCacheValue(snapshot, this,
this::projectFullSchema);
+ return withMissingTableRepair(() -> {
Review Comment:
Fixed in 67c364208a9. getBaseSchemaForDisplay(boolean) now wraps the
complete table read in guarded missing-table repair, preserving declared
nullability and the existing hidden-column projection. A direct schema-display
API test raises NoSuchTableException during withIcebergTableGeneration() and
verifies lookup repair and the retained exception cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
