github-actions[bot] commented on code in PR #69385:
URL: https://github.com/apache/doris/pull/69385#discussion_r4375093843
##########
fe/fe-filesystem/fe-filesystem-spi/src/main/java/org/apache/doris/filesystem/spi/S3CompatibleFileSystem.java:
##########
@@ -65,6 +79,15 @@ protected S3CompatibleFileSystem(ObjStorage<?> objStorage,
boolean usePathStyle,
this.supportedSchemes = supportedSchemes;
}
+ /**
+ * Supplies mutable host settings without rebuilding cached storage
clients or rebinding
+ * provider properties. The supplier must be thread-safe and perform no
I/O; each glob call
+ * reads it once so its entire listing uses the same policy.
+ */
+ public void
setDeterministicPathOptionsSupplier(Supplier<DeterministicPathOptions>
supplier) {
Review Comment:
[P2] Bump the filesystem API major for this public SPI addition
This adds `setDeterministicPathOptionsSupplier` and
`DeterministicPathOptions` to the public filesystem SPI, but
`fe/fe-filesystem/pom.xml` still stamps plugins with API version `6.0`. A
provider rebuilt to call this setter during `create()` can therefore pass
`ApiVersionGate` on a pre-change API-6 FE. Since filesystem classes load
parent-first, it then resolves the older host superclass, where the new symbols
are absent, and filesystem creation fails with a linkage error. The gate
compares only majors and explicitly relies on every SPI addition incrementing
that major. Bump `filesystem.plugin.api.version` in the same change; also
consider including this superclass and record in the surface snapshot, which
currently omits them. This concerns newer providers on older hosts, rather than
unchanged bundled providers on this head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
