OIiveirra commented on code in PR #69593:
URL: https://github.com/apache/doris/pull/69593#discussion_r4374255433


##########
regression-test/suites/types/complex_types/map_uniq_with_local_tvf.groovy:
##########
@@ -45,11 +34,24 @@ suite("map_uniq_with_local_tvf", "p0") {
             "disable_auto_compaction" = "false"
             ); """
 
-    qt_sql """
-           insert into ${table_name} select * from local(
-                       "file_path" = "${outFilePath}/mm.orc",
-                       "backend_id" = "${be_id}",
-                       "format" = "orc");"""
+    String bucket = getS3BucketName()
+    String key = "regression/local_tvf_migration/${UUID.randomUUID()}/mm.orc"
+    def s3Client = getS3Client()
+    s3Client.putObject(bucket, key, new File(context.config.dataPath, 
"types/complex_types/mm.orc"))

Review Comment:
   Fixed in 0350472ab310bdafa59577fd1f2e2cb5c2d36744; the same adaptation is 
applied to the other affected branch PRs. Both ORC fixture loads now use the 
already-declared Azure Blob SDK for Azure upload and cleanup, and retain the 
AWS client for S3-compatible providers. The TVF receives the provider and 
resolved endpoint; the Azure placeholder maps to the account endpoint, while 
explicit endpoints are preserved. Original ORC files, table definitions and all 
count/value assertions are unchanged. All eight branch scripts compiled with 
the existing SDK dependencies. Twelve loopback tests using the real Azure/S3 
SDKs verified byte-identical uploads, endpoint selection and cleanup after 
successful or injected-failing SQL calls. SQL was intercepted in that probe; no 
Doris runtime regression or live-cloud validation is claimed. No production or 
framework dependency changes were made.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to