lets-order-some-fries commented on PR #67238:
URL: https://github.com/apache/doris/pull/67238#issuecomment-6393463388
@924060929 P0 (builds 1068364, 1072663) and cloud_p0 (1072662) on the
previous head each failed one test,
`doc/sql-manual/sql-functions/doc_date_functions_test.groovy`. In the 10-18
runs it is line 107, the mixed-types check of `day_ceil('2023-07-13 22:28:18',
'2020-01-01 00:00:00+08:00')`: expected `2023-07-14 00:00:00`, got `2023-07-14
00:00:00+08:00`.
The cause was my scoring change in `SearchSignature`, not the reorder. It
made every `*_ceil` / `*_floor` call that mixes a zoned and a zone-less literal
bind its two-TIMESTAMPTZ overload, while the suite requires such a call to
equal its all-DATETIME result.
This push drops that change and its two tests, so `SearchSignature` matches
master. A `*_diff` call mixing one zoned and one zone-less literal now binds
DATETIMEV2 by list order, the rule `*_ceil` / `*_floor` already follow; a new
test pins it. The push also merges master to resolve the conflict with #69271.
The 08-28 head, which had only the reorder, passed P0, cloud_p0 and vault_p0.
The push dismissed your approval. Could you take another look, and run
buildall?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
