github-actions[bot] commented on code in PR #69391:
URL: https://github.com/apache/doris/pull/69391#discussion_r4366768058
##########
gensrc/thrift/BackendService.thrift:
##########
@@ -47,6 +47,108 @@ struct TTabletStatResult {
2: optional list<TTabletStat> tablet_stat_list
}
+// Custom Routine Load properties cross the SQL-user to BE-process trust
boundary.
+// Keep this allowlist shared by FE analysis and BE consumer initialization.
New
+// librdkafka options must be reviewed before being exposed to SQL users. Never
+// allow shell commands, loadable modules/providers, or arbitrary local paths.
+const set<string> KAFKA_ALLOWED_PROPERTIES = [
+ "allow.auto.create.topics",
+ "api.version.fallback.ms",
+ "api.version.request",
+ "api.version.request.timeout.ms",
+ "auto.offset.reset",
+ "broker.address.family",
+ "broker.address.ttl",
+ "broker.version.fallback",
+ "check.crcs",
+ "client.dns.lookup",
+ "client.id",
+ "connections.max.idle.ms",
+ "enable.partition.eof",
+ "enable.sasl.oauthbearer.unsecure.jwt",
+ "enable.ssl.certificate.verification",
+ "fetch.error.backoff.ms",
+ "fetch.max.bytes",
+ "fetch.message.max.bytes",
+ "fetch.min.bytes",
+ "fetch.wait.max.ms",
+ "group.id",
+ "group.instance.id",
+ "heartbeat.interval.ms",
+ "isolation.level",
+ "max.partition.fetch.bytes",
+ "max.poll.interval.ms",
+ "metadata.max.age.ms",
+ "partition.assignment.strategy",
+ "queued.max.messages.kbytes",
+ "queued.min.messages",
+ "receive.message.max.bytes",
+ "reconnect.backoff.max.ms",
+ "reconnect.backoff.ms",
+ "retry.backoff.max.ms",
+ "retry.backoff.ms",
+ // Only the value "0" is accepted; ticket management is external.
+ "sasl.kerberos.min.time.before.relogin",
+ "sasl.kerberos.principal",
+ "sasl.kerberos.service.name",
+ "sasl.mechanism",
+ "sasl.mechanisms",
+ "sasl.oauthbearer.client.id",
Review Comment:
[P2] Preserve the supported OIDC credential aliases
The bundled librdkafka 2.16 also accepts
`sasl.oauthbearer.client.credentials.client.id` and
`sasl.oauthbearer.client.credentials.client.secret` as exact aliases of the two
admitted options ([upstream
configuration](https://github.com/confluentinc/librdkafka/blob/v2.16.0/CONFIGURATION.md)).
A previously working OIDC job using either long name now fails FE runtime
validation or new-BE initialization. Adding the short names with ALTER cannot
repair the persisted job: `prepareModifyProperties()` merges with `putAll()`,
leaving the rejected alias key in the effective map. Please admit both aliases
in this shared set, or canonicalize them consistently before FE/BE validation,
and cover CREATE plus recovery/ALTER of an existing alias-based job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
