github-actions[bot] commented on code in PR #68607: URL: https://github.com/apache/doris/pull/68607#discussion_r4365933499
########## be/test/storage/index/inverted/snii/testdata/compatibility_corpus/english_phrase.expect: ########## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# sample=english_phrase doc_count=20 lower_case=true parser=english support_phrase=true +5 hello 0 0,10,18,19 0 4,5,6,11 +5 hello%20world 0 0,10,18,19 0 4,5,6,11 +5 nonexistent 0 0 4,5,6,11 +5 the 0 2 0 4,5,6,11 +5 重复 0 0 4,5,6,11 +5 %1fhidden 0 12 0 4,5,6,11 +5 prefix 0 14 0 4,5,6,11 +5 tok 0 16 0 4,5,6,11 +5 0 0 4,5,6,11 +6 hello%20world 0 0,10,19 0 4,5,6,11 +6 again%20and 0 10 0 4,5,6,11 +6 alpha%20beta%20gamma 0 15 0 4,5,6,11 +6 hello%20nonexistent 0 0 4,5,6,11 +7 hello%20world 0 0,10 0 4,5,6,11 +7 world%20hello 0 0,19 0 4,5,6,11 +7 again%20and%20again 0 10 0 4,5,6,11 +7 alpha%20beta 0 15 0 4,5,6,11 +7 重复%20词元 0 0 4,5,6,11 +7 brown%20fox 0 2 0 4,5,6,11 +7 hello 0 0,10,18,19 0 4,5,6,11 +8 hello%20wor 0 0,10 0 4,5,6,11 +8 prefix%20pre 0 14 0 4,5,6,11 +8 alpha%20be 0 15 0 4,5,6,11 +8 again%20ag 0 0 4,5,6,11 +8 sing 0 8 0 4,5,6,11 +0 single 0 8 0 4,5,6,11 +0 hello%20world%20hello%20doris 0 0,3,10,18,19 0 4,5,6,11 Review Comment: [P1] Reconcile the multiword equality expectations before enabling the corpus This type-0 EQUAL_QUERY expects a union, but open_sample constructs a FULLTEXT reader and the current lower_match sets require_all=true for EQUAL_QUERY. The shared engine therefore intersects the analyzed terms: this committed image returns only doc 0, rather than 0,3,10,18,19 (for example, doc 18 contains only hello). The same stale observation appears in english_docs, unicode_phrase and english_phrase_nolower; english_array_phrase returns 0,8 rather than its expected 0,5,6,8. Because this PR removes the default skip, ordinary BE unit-test runs now report these five mismatches in every cache mode. Please reconcile/regenerate all five equality expectations against the intended current semantics before making the corpus mandatory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
