englefly commented on code in PR #69028:
URL: https://github.com/apache/doris/pull/69028#discussion_r4356778779
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java:
##########
@@ -545,7 +554,7 @@ public void afterCommitTxnResp(CommitTxnResponse
commitTxnResponse, List<TabletC
}
}
Env env = Env.getCurrentEnv();
- env.getAnalysisManager().updateUpdatedRows(updatedRows);
+ env.getAnalysisManager().updateUpdatedRows(updatedRows, dbId,
reportedPartitions);
Review Comment:
不修. 这是cloud模式在原代码上已有的问题. 这个pr 修复了3种commit 里最常见的1种. 对另外两种没有改进也没有损坏.
没有处理的两种commit:
1. FE 显式事务（BEGIN; INSERT ...; COMMIT;
2. BE 直连提交（enable_stream_load_commit_txn_on_be=true 的非 MoW/non-TSO stream
load )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
