yiguolei commented on code in PR #16891:
URL: https://github.com/apache/doris/pull/16891#discussion_r1111380030
##########
be/src/vec/exec/scan/new_olap_scanner.cpp:
##########
@@ -385,6 +385,23 @@ Status NewOlapScanner::_init_return_columns() {
return Status::OK();
}
+doris::TabletStorageType NewOlapScanner::get_storage_type() {
+ int local_reader = 0;
+ for (const auto& reader : _tablet_reader_params.rs_readers) {
+ if (reader->rowset()->rowset_meta()->resource_id().empty()) {
Review Comment:
// 3. remote scan thread pool
_remote_scan_thread_pool.reset(
new
PriorityThreadPool(config::doris_scanner_thread_pool_thread_num,
config::doris_scanner_thread_pool_queue_size, "remote_scan"));
maybe we should add another config for remote scanner thread pool. because
we may increase the remote scanner thread pool to 10000 and it is not the same
as local scanner thread pool.
And not use priority thread pool, we could set min threads and max threads
to avoid too many threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
