OIiveirra opened a new pull request, #69473:
URL: https://github.com/apache/doris/pull/69473
### What problem does this PR solve?
Issue Number: N/A (no public GitHub issue)
Problem Summary:
The retained LakeSoul scanner logs complete scanner parameters at INFO,
including object storage credentials carried in `options`. The FE scan node
also logs complete catalog properties at DEBUG.
Log only the query ID and batch size when opening the scanner, and remove
the catalog-property dump. Authentication options continue to reach the reader
unchanged.
Add focused regression tests and an explicit `lakesoul-scanner-tests` Maven
profile so the deprecated scanner can be tested while remaining excluded from
default builds.
### Release note
Prevent sensitive LakeSoul scanner parameters and catalog properties from
being written to logs.
### Check List (For Author)
- Test
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
Validation on JDK 17:
- `LakeSoulJniScannerTest`: 3 tests passed, covering INFO, DEBUG, and a
missing query ID; credentials still reach the native reader.
- `LakeSoulScanNodeTest`: 1 test passed, verifying credentials stay in
scan options and out of DEBUG logs.
- Restoring the original production logging makes all 4 tests fail on
credential-leak assertions; restoring the fix makes all 4 pass.
- Targeted Checkstyle: 0 violations. `git diff --check` passed.
Native I/O is isolated with Mockito. No live LakeSoul SQL scan was run.
- Behavior changed:
- [ ] No.
- [x] Yes. Scanner startup logs contain the query ID and batch size
instead of the full parameters; FE no longer logs complete catalog properties.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
