HappenLee commented on PR #69255: URL: https://github.com/apache/doris/pull/69255#issuecomment-6337780359
I think these two parameters need tighter resource bounds and a different default: 1. **`pool_size`: require a positive value and cap the effective pool size at the CPU core count of the executing BE.** The current FE and BE checks already reject zero and negative values; please retain those checks. The missing part is the upper bound: `pool_size = 10000` is currently accepted, and `_start_pool_initialization()` sizes the process vector and launches an initialization thread per slot, each attempting to start a Python process. A single function should not be able to attempt 10,000 Python processes on a BE. Enforce the CPU-based bound before allocation or process startup on each BE, including heterogeneous clusters, and make sure the default of 3 also respects that bound on smaller BEs. Please cover zero, negative values, the CPU-count boundary, and an excessive value such as 10000 in tests. 2. **`auto_suspend`: please use 4 hours (`14400` seconds) as the default instead of `-1`.** With pools now isolated per function, the current default keeps every initialized function's processes resident indefinitely after it becomes idle. Resource consumption therefore accumulates as more functions are used. Reclaiming a pool after 4 hours without active clients is a more reasonable default; the next invocation can recreate it. If disabling suspension is supported, it should require explicitly setting `-1`. Please keep this default consistent across function creation, catalog metadata, Thrift, and BE fallback paths, and cover the omitted-property behavior and idle reclamation/recreation in tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
