OIiveirra commented on PR #69032:
URL: https://github.com/apache/doris/pull/69032#issuecomment-6310529338

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#69032
   commit: 0e3511ad54e398130b104e715f0f114fefb62ddb
   base: 9e98d3623892bf133dc44149af2fcdc14226ecc1
   reviewed_at: 2026-10-21T15:27+08:00
   reviewer: OIiveirra
   model: gpt-6.1-sol
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 0, nit: 0}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - 
`fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/CheckDataTypes.java:118-131`
 — The former typed-NULL spatial AggState admission gap is closed through 
registered nested aggregate legality and signature checks, while the original 
descriptor metadata/nullability remain intact.
   - 
`regression-test/suites/external_table_p0/iceberg/test_iceberg_spatial_v3.groovy:374-425`
 — Ordinary-key spatial-value MAP_AGG/COUNT_MAP/MIN_MAP/MAX_MAP state-to-merge 
and typed-NULL positive controls are source-covered; SUM_MAP/AVG_MAP retain 
numeric-value constraints.
   - This was a source-only review: no build, tests, SQL or cluster access were 
performed by the reviewers. Author validation is separate evidence.
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to