hubgeter opened a new pull request, #69376:
URL: https://github.com/apache/doris/pull/69376
### What problem does this PR solve?
Issue Number: N/A
Related PR: #68854, #69338
Problem Summary:
The Iceberg data, position-delete, and Hive Parquet writers created their
output file before validating the requested Parquet compression codec. For an
unsupported codec, the Iceberg data writer then attempted to delete an open
file, while the other writers returned after creating the file. This made error
cleanup depend on filesystem behavior and could leave an orphan file. Resolve
the codec before calling `create_file` so invalid codecs fail without creating
any output file, and add a regression test for the failure path.
### Release note
None
### Check List (For Author)
- Test
- [ ] Regression test
- [x] Unit Test: added `UnsupportedParquetCodecDoesNotCreateFile`; CI
will run it.
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
- Behavior changed:
- [x] No.
- [ ] Yes.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
