yujun777 opened a new pull request, #69372:
URL: https://github.com/apache/doris/pull/69372

   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #69311, #69268, #63639
   
   Problem Summary: #69311 renamed the row binlog (the change stream IVM reads) 
to **changelog** and rejected the legacy keys `binlog.format` / 
`binlog.need_historical_value` in every DDL. Two test files merged just before 
it fell outside that rename sweep and now fail:
   
   1. `regression-test/suites/mtmv_p0/ivm/test_ivm_datetime_sequence.groovy` 
(from #69268) — creates its IVM base tables with `"binlog.enable" = "true", 
"binlog.format" = "ROW", "binlog.need_historical_value" = "true"`, which CREATE 
TABLE now rejects.
   2. `RelationImpliedPredicateTest#testIvmOutputPredicatesSkipHiddenColumns` 
(from #63639) — same legacy properties in the base-table DDL, and it gates the 
creation on `enable_feature_binlog` instead of the new 
`enable_feature_changelog`.
   
   Fix: switch both to `"changelog.enable" = "true"` (plus 
`"changelog.need_historical_value" = "true"` where the before-image is needed), 
drop the rejected `binlog.format`, and use `enable_feature_changelog` as the 
feature gate in the FE unit test. Related IVM trace issue: 
https://github.com/apache/doris/issues/65418 .
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test
       - Unit Test: `run-fe-ut.sh --run 
org.apache.doris.nereids.mv.RelationImpliedPredicateTest,org.apache.doris.mtmv.ivm.IvmUtilTest`
 on top of current master — 35 tests, 0 failures.
       - Regression Test: FE+BE rebuilt from current master, 
`run-regression-test.sh --run -d mtmv_p0 -s test_ivm_datetime_sequence` — "All 
suites success"; query results are unchanged by the property rename, so the 
`.out` is untouched.
   - Behavior changed: No
   - Does this need documentation: No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to