yujun777 commented on PR #69212: URL: https://github.com/apache/doris/pull/69212#issuecomment-6288109410
Nice fix, the direction looks correct to me — I verified that none of the STRICT sql-mode bits are read anywhere on the FE query/plan path, so ignoring `STRICT_TRANS_TABLES` in the sync-MV compatibility check does not change rewrite semantics. One small, non-blocking question: `STRICT_ALL_TABLES` has exactly the same status in Doris — apart from the encode/decode helpers in `SqlModeHelper`, there is no consumer of that bit in FE or BE either. Would it make sense to ignore it as well (just one more bit in the mask), so the two strict bits stay symmetric? If you kept it strict deliberately, a short note in the PR description explaining why would be enough for me. Either way this does not block the merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
